[3팀 김진현][Chapter 1-1] 프레임워크 없이 SPA 만들기 #15
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinhyeon0810
changed the title
hty0525
reviewed
Sep 27, 2024
| </li> | ||
| </ul> | ||
| </nav>`; | ||
| } |
There was a problem hiding this comment.
map으로 반복문 돌리는거 말씀하시는거죠? ㅎㅎ 유지보수 측면에서 좋은 방법인거같습니다
KimDanwoo
reviewed
Sep 27, 2024
|
|
||
| const profileLinkClass = | ||
| currentPath === "/profile" ? "text-blue-600" : "text-gray-600"; | ||
|
|
There was a problem hiding this comment.
경로부분이 하드코딩 되어있는데 상수로 뺀다면 더 편하게 관리할 수 있을거같아요!
rami0617
reviewed
Sep 27, 2024
| export const user = new User(); | ||
| export function isLoggedIn() { | ||
| return user?.preferences?.username?.length > 0; | ||
| } |
There was a problem hiding this comment.
export �const isLoggedIn =() => user?.preferences?.username?.length > 0;
이런식으로 축약해서 사용할 수도 있을 것 같습니다~!
There was a problem hiding this comment.
오호 넵 화살표함수로 작성하니 더 깔끔해보여 좋은거같습니다!
| errorBoundary.id = "error-boundary"; | ||
| errorBoundary.textContent = `오류 발생! ${event.message}`; | ||
| document.body.appendChild(errorBoundary); | ||
| }); |
There was a problem hiding this comment.
appendChild를 해주게 되면 repaint나 reflow가 일어날 수 있습니다. 미리 error-boundary를 만들고 에러가 발생하면 보여주는건 어떨까요~?
| export function HomePage() { | ||
| let html; | ||
| html = ` <div class="bg-gray-100 min-h-screen flex justify-center"> | ||
| <div class="max-w-md w-full"> |
There was a problem hiding this comment.
html을 선언하고 한번만 할당하고 있어 const html = `` 이런식으로 바꿔 보는건 어떨까요~?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
과제 체크포인트
기본과제
1) 라우팅 구현:
2) 사용자 관리 기능:
3) 프로필 페이지 구현:
4) 컴포넌트 기반 구조 설계:
5) 상태 관리 초기 구현:
6) 이벤트 처리 및 DOM 조작:
7) 기본적인 에러 처리:
심화과제
1) 고급 라우팅
2) 고급 이벤트 처리
리뷰 받고 싶은 내용
궁금한 점
과제를 수행하면서 느낀점
과제 시작 전 생각
과제 제출 후 생각
기타
과제 난이도